From 197c9e5152fd6524c82977001a759c36c644f8e5 Mon Sep 17 00:00:00 2001 From: Pavel Boldyrev <627562+bpg@users.noreply.github.com> Date: Wed, 15 Feb 2023 16:55:31 -0500 Subject: [PATCH] fix(vm): `proxmox_virtual_environment_file.changed` stored as `true` at file creation (#240) This trigger "changed outside of Terraform" detection on the resource when Terraform re-applies the same plan second time. --- proxmoxtf/resource_virtual_environment_file.go | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/proxmoxtf/resource_virtual_environment_file.go b/proxmoxtf/resource_virtual_environment_file.go index 2d560a70..68c91188 100644 --- a/proxmoxtf/resource_virtual_environment_file.go +++ b/proxmoxtf/resource_virtual_environment_file.go @@ -594,9 +594,12 @@ func resourceVirtualEnvironmentFileRead( err = d.Set(mkResourceVirtualEnvironmentFileFileTag, fileTag) diags = append(diags, diag.FromErr(err)...) - sourceFileBlock[mkResourceVirtualEnvironmentFileSourceFileChanged] = lastFileMD != fileModificationDate || - lastFileSize != fileSize || - lastFileTag != fileTag + // just to make the logic easier to read + changed := false + if lastFileMD != "" && lastFileSize != 0 && lastFileTag != "" { + changed = lastFileMD != fileModificationDate || lastFileSize != fileSize || lastFileTag != fileTag + } + sourceFileBlock[mkResourceVirtualEnvironmentFileSourceFileChanged] = changed err = d.Set(mkResourceVirtualEnvironmentFileSourceFile, sourceFile) diags = append(diags, diag.FromErr(err)...)