From 328acd80df81a644fd939f931d5135b193ee1e9e Mon Sep 17 00:00:00 2001
From: Lucas Hahn <lucas.hahn@novum-rgi.de>
Date: Fri, 8 May 2020 09:02:11 +0200
Subject: [PATCH] set retries to default 1 and add guard

---
 proxmox/virtual_environment_vm.go            | 5 +++++
 proxmoxtf/resource_virtual_environment_vm.go | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/proxmox/virtual_environment_vm.go b/proxmox/virtual_environment_vm.go
index 7f45a1df..9864827f 100644
--- a/proxmox/virtual_environment_vm.go
+++ b/proxmox/virtual_environment_vm.go
@@ -28,6 +28,11 @@ func (c *VirtualEnvironmentClient) CloneVM(nodeName string, vmID int, retries in
 	resBody := &VirtualEnvironmentVMMoveDiskResponseBody{}
 	var err error
 
+	// just a guard in case someone sets retries to 0 unknowingly
+	if retries <= 0 {
+		retries = 1
+	}
+
 	for i := 0; i < retries; i++ {
 		err = c.DoRequest(hmPOST, fmt.Sprintf("nodes/%s/qemu/%d/clone", url.PathEscape(nodeName), vmID), d, resBody)
 
diff --git a/proxmoxtf/resource_virtual_environment_vm.go b/proxmoxtf/resource_virtual_environment_vm.go
index bc87a825..fe7ac8de 100644
--- a/proxmoxtf/resource_virtual_environment_vm.go
+++ b/proxmoxtf/resource_virtual_environment_vm.go
@@ -34,7 +34,7 @@ const (
 	dvResourceVirtualEnvironmentVMCloneDatastoreID                  = ""
 	dvResourceVirtualEnvironmentVMCloneNodeName                     = ""
 	dvResourceVirtualEnvironmentVMCloneFull                         = true
-	dvResourceVirtualEnvironmentVMCloneRetries                      = 0
+	dvResourceVirtualEnvironmentVMCloneRetries                      = 1
 	dvResourceVirtualEnvironmentVMCPUArchitecture                   = "x86_64"
 	dvResourceVirtualEnvironmentVMCPUCores                          = 1
 	dvResourceVirtualEnvironmentVMCPUHotplugged                     = 0