From 34df9773c34b43ba39b5d8505b5916b52f87ff3e Mon Sep 17 00:00:00 2001 From: bitchecker Date: Thu, 21 Dec 2023 01:40:11 +0100 Subject: [PATCH] fix(provider): allow FQDN for `ssh.node.address` in provider's config (#824) * fix(provider): removed ip check/limitation to mkProviderSSHNode It is now possible to use an FQDN instead of an IP Address when the SSH node is configured Changes to be committed: modified: proxmoxtf/provider/schema.go Signed-off-by: bitchecker * fix(docs): Updating documentation after the code updates Signed-off-by: bitchecker --------- Signed-off-by: bitchecker --- docs/index.md | 2 +- proxmoxtf/provider/schema.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/index.md b/docs/index.md index 510a6792..ff98dc18 100644 --- a/docs/index.md +++ b/docs/index.md @@ -209,6 +209,6 @@ Proxmox `provider` block: - `node` - (Optional) The node configuration for the SSH connection. Can be specified multiple times to provide configuration fo multiple nodes. - `name` - (Required) The name of the node. - - `address` - (Required) The IP address of the node. + - `address` - (Required) The FQDN/IP address of the node. - `port` - (Optional) SSH port of the node. Defaults to 22. - `tmp_dir` - (Optional) Use custom temporary directory. (can also be sourced from `PROXMOX_VE_TMPDIR`) diff --git a/proxmoxtf/provider/schema.go b/proxmoxtf/provider/schema.go index 5dc0b790..644ab34a 100644 --- a/proxmoxtf/provider/schema.go +++ b/proxmoxtf/provider/schema.go @@ -155,7 +155,7 @@ func createSchema() map[string]*schema.Schema { Type: schema.TypeString, Required: true, Description: "The address of the Proxmox VE node.", - ValidateFunc: validation.IsIPAddress, + ValidateFunc: validation.StringIsNotEmpty, }, mkProviderSSHNodePort: { Type: schema.TypeInt,