mirrors/terraform-provider-proxmox
0
0
Fork 0
mirror of https://github.com/bpg/terraform-provider-proxmox.git synced 2025-07-02 19:43:00 +00:00
Code

fix(firewall): Improve firewall resources argument validation (#359)

Browse Source 
Make sure VM / Container rules, SGs, IPSets are always include `node_name` along with `vm_id`, `container_id`.
This commit is contained in:
Pavel Boldyrev 2023-06-02 06:38:27 -04:00 committed by GitHub
parent 9587c6383c
commit 8c1f246b5a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
proxmoxtf/resource/firewall/selector.go
View File

@ -30,14 +30,16 @@ func selectorSchema() map[string]*schema.Schema {
Description: "The name of the node.", Description: "The name of the node.",
}, },
mkSelectorVMID: { mkSelectorVMID: {
Type: schema.TypeInt, Type: schema.TypeInt,
Optional: true, Optional: true,
Description: "The ID of the VM to manage the firewall for.", Description: "The ID of the VM to manage the firewall for.",
RequiredWith: []string{mkSelectorNodeName},
}, },
mkSelectorContainerID: { mkSelectorContainerID: {
Type: schema.TypeInt, Type: schema.TypeInt,
Optional: true, Optional: true,
Description: "The ID of the container to manage the firewall for.", Description: "The ID of the container to manage the firewall for.",
RequiredWith: []string{mkSelectorNodeName},
}, },
} }
} }
@ -46,6 +48,9 @@ func selectorSchemaMandatory() map[string]*schema.Schema {
s := selectorSchema() s := selectorSchema()
s[mkSelectorNodeName].Optional = false s[mkSelectorNodeName].Optional = false
s[mkSelectorNodeName].Required = true s[mkSelectorNodeName].Required = true
// required attributes can't be included in RequiredWith
s[mkSelectorVMID].RequiredWith = nil
s[mkSelectorContainerID].RequiredWith = nil
return s return s
} }