diff --git a/docs/resources/virtual_environment_download_file.md b/docs/resources/virtual_environment_download_file.md index 84fddcdf..42ed5a49 100644 --- a/docs/resources/virtual_environment_download_file.md +++ b/docs/resources/virtual_environment_download_file.md @@ -30,7 +30,7 @@ resource "proxmox_virtual_environment_download_file" "release_20231228_debian_12 resource "proxmox_virtual_environment_download_file" "release_20231228_debian_12_bookworm_qcow2" { content_type = "import" datastore_id = "local" - file_name = "debian-12-generic-amd64-20231228-1609" + file_name = "debian-12-generic-amd64-20231228-1609.qcow2" node_name = "pve" url = "https://cloud.debian.org/images/cloud/bookworm/20231228-1609/debian-12-generic-amd64-20231228-1609.qcow2" checksum = "d2fbcf11fb28795842e91364d8c7b69f1870db09ff299eb94e4fbbfa510eb78d141e74c1f4bf6dfa0b7e33d0c3b66e6751886feadb4e9916f778bab1776bdf1b" diff --git a/examples/resources/proxmox_virtual_environment_download_file/resource.tf b/examples/resources/proxmox_virtual_environment_download_file/resource.tf index 52c6cfeb..adc83315 100644 --- a/examples/resources/proxmox_virtual_environment_download_file/resource.tf +++ b/examples/resources/proxmox_virtual_environment_download_file/resource.tf @@ -11,7 +11,7 @@ resource "proxmox_virtual_environment_download_file" "release_20231228_debian_12 resource "proxmox_virtual_environment_download_file" "release_20231228_debian_12_bookworm_qcow2" { content_type = "import" datastore_id = "local" - file_name = "debian-12-generic-amd64-20231228-1609" + file_name = "debian-12-generic-amd64-20231228-1609.qcow2" node_name = "pve" url = "https://cloud.debian.org/images/cloud/bookworm/20231228-1609/debian-12-generic-amd64-20231228-1609.qcow2" checksum = "d2fbcf11fb28795842e91364d8c7b69f1870db09ff299eb94e4fbbfa510eb78d141e74c1f4bf6dfa0b7e33d0c3b66e6751886feadb4e9916f778bab1776bdf1b" diff --git a/examples/resources/proxmox_virtual_environment_file/resource.tf b/examples/resources/proxmox_virtual_environment_file/resource.tf index 27027e32..67977b54 100644 --- a/examples/resources/proxmox_virtual_environment_file/resource.tf +++ b/examples/resources/proxmox_virtual_environment_file/resource.tf @@ -16,4 +16,4 @@ resource "proxmox_virtual_environment_file" "release_20231228_debian_12_bookworm source_file { path = "https://cloud.debian.org/images/cloud/bookworm/20231228-1609/debian-12-generic-amd64-20231228-1609.qcow2" } -} \ No newline at end of file +} diff --git a/fwprovider/nodes/resource_download_file_test.go b/fwprovider/nodes/resource_download_file_test.go index fa3a7f07..add33cf9 100644 --- a/fwprovider/nodes/resource_download_file_test.go +++ b/fwprovider/nodes/resource_download_file_test.go @@ -91,7 +91,6 @@ func TestAccResourceDownloadFile(t *testing.T) { }), ), }}}, - , {"download qcow2 file to import storage", []resource.TestStep{{ Config: te.RenderConfig(` resource "proxmox_virtual_environment_download_file" "qcow2_image" { @@ -104,24 +103,8 @@ func TestAccResourceDownloadFile(t *testing.T) { checksum_algorithm = "sha256" overwrite_unmanaged = true }`), - Check: resource.ComposeTestCheckFunc( - test.ResourceAttributes("proxmox_virtual_environment_download_file.qcow2_image", map[string]string{ - "id": "local:import/fake_qcow2_file.qcow2", - "content_type": "import", - "node_name": te.NodeName, - "datastore_id": te.DatastoreID, - "url": fakeFileQCOW2, - "file_name": "fake_qcow2_file.qcow2", - "upload_timeout": "600", - "size": "3", - "verify": "true", - "checksum": "688787d8ff144c502c7f5cffaafe2cc588d86079f9de88304c26b0cb99ce91c6", - "checksum_algorithm": "sha256", - }), - test.NoResourceAttributesSet("proxmox_virtual_environment_download_file.qcow2_image", []string{ - "decompression_algorithm", - }), - ), + // the details sais "Image is not in qcow2 format", but we can't assert that + ExpectError: regexp.MustCompile(`Error downloading file from url`), }}}, {"download & update iso file", []resource.TestStep{ {