* feat(file): Add support to set the file mode GH-733 [1] implemented basic support for hook scripts, but the authors "did not manage to find time to work on" [2] also including support to set the file mode. This small but important feature makes the use of the `proxmox_virtual_environment_container.hook_script_file_id` [3] and `virtual_environment_vm.hook_script_file_id` [34] attributes basically useless when not combined with the manual step of making the uploaded file executable (manually running `chmod +x /path/to/script` or using other methods, based on the storage backend). Using the `hook_script_file_id` on its own also causes all planned and applies changes in the same execution to not be saved in the state because the Proxmox VE API responses with a HTTP `500` because the uploaded and assigned file is not executable. This pull request implements the missing feature to set the file mode by adding a new `file_mode` attribute of type `string` where an octal-formatted value can be passed, e.g. `0700` or only `600`. Note that the support for the octal prefixes `0o` and `0x` are not supported to reduced the complexity, even though Go of course support it, including the used `os.FileMode` type [5]. Changing the file mode also causes the file to be replaced, which is true for almost any attribute in the `proxmox_virtual_environment_file` resource, to ensure that the file mode can also be changed after the initial creation. [1]: https://github.com/bpg/terraform-provider-proxmox/pull/733 [2]: https://github.com/bpg/terraform-provider-proxmox/pull/733#issuecomment-2096716738 [3]: https://registry.terraform.io/providers/bpg/proxmox/latest/docs/resources/virtual_environment_container#hook_script_file_id [4]: https://registry.terraform.io/providers/bpg/proxmox/latest/docs/resources/virtual_environment_vm#hook_script_file_id [5]: https://pkg.go.dev/os#FileMode Related to GH-570 Related to GH-733 Signed-off-by: Sven Greb <development@svengreb.de> --------- Signed-off-by: Sven Greb <development@svengreb.de> |
||
---|---|---|
.devcontainer | ||
.github | ||
.vscode | ||
docs | ||
example | ||
examples | ||
fwprovider | ||
proxmox | ||
proxmoxtf | ||
templates | ||
tools | ||
utils | ||
.all-contributorsrc | ||
.gitignore | ||
.golangci.yml | ||
.goreleaser.yaml | ||
.lycheeignore | ||
.markdownlint.json | ||
.markdownlintignore | ||
.mergify.yml | ||
.release-please-manifest.json | ||
CHANGELOG.md | ||
CODE_OF_CONDUCT.md | ||
CONTRIBUTING.md | ||
CONTRIBUTORS.md | ||
example.tfrc | ||
go.mod | ||
go.sum | ||
HISTORY.md | ||
LICENSE | ||
main.go | ||
Makefile | ||
qodana.yaml | ||
README.md | ||
release-please-config.json | ||
terraform-registry-manifest.json | ||
testacc |
Terraform Provider for Proxmox
A Terraform / OpenTofu Provider that adds support for Proxmox solutions.
This repository is a fork of https://github.com/danitso/terraform-provider-proxmox which is no longer maintained.
Compatibility Promise
This provider is compatible with the latest version of Proxmox VE (currently 8.2). While it may work with older 7.x versions, it is not guaranteed to do so.
While the provider is on version 0.x, it is not guaranteed to be backward compatible with all previous minor versions. However, we will try to maintain backward compatibility between provider versions as much as possible.
Requirements
- Proxmox Virtual Environment 8.x
- TLS 1.3 for the Proxmox API endpoint (legacy TLS 1.2 is optionally supported)
- Terraform 1.5.x+ or OpenTofu 1.6.x
- Go 1.22 (to build the provider plugin)
Using the Provider
You can find the latest release and its documentation in the Terraform Registry.
Testing the Provider
To test the provider, simply run make test
.
make test
Tests are limited to regression tests, ensuring backward compatibility.
A limited number of acceptance tests are available in the proxmoxtf/test
directory, mostly for "new" functionality implemented using the Terraform Provider Framework.
These tests are not run by default, as they require a Proxmox VE environment to be available.
They can be run using make testacc
. The Proxmox connection can be configured using environment variables; see the provider documentation for details.
Deploying the Example Resources
There are a number of TF examples in the example
directory, which can be used to deploy a Container, VM, or other Proxmox resources in your test Proxmox environment.
The following assumptions are made about the test environment:
- It has one node named
pve
- The node has local storages named
local
andlocal-lvm
- The "Snippets" content type is enabled in the
local
storage
Create example/terraform.tfvars
with the following variables:
virtual_environment_endpoint = "https://pve.example.doc:8006/"
virtual_environment_ssh_username = "terraform"
virtual_environment_api_token = "root@pam!terraform=00000000-0000-0000-0000-000000000000"
Then run make example
to deploy the example resources.
If you don't have a free Proxmox cluster to play with, there is a dedicated how-to tutorial on how to set up Proxmox inside a VM and run make example
on it.
Future Work
The provider is using the Terraform SDKv2, which is considered legacy and is in maintenance mode. Work has started to migrate the provider to the new Terraform Plugin Framework, with the aim of releasing it as a new major version 1.0.
Known Issues
Disk Images Cannot Be Imported by Non-PAM Accounts
Due to limitations in the Proxmox VE API, certain actions need to be performed using SSH. This requires the use of a PAM account (standard Linux account).
Disk Images from VMware Cannot Be Uploaded or Imported
Proxmox VE does not currently support VMware disk images directly. However, you can still use them as disk images by using this workaround:
resource "proxmox_virtual_environment_file" "vmdk_disk_image" {
content_type = "iso"
datastore_id = "datastore-id"
node_name = "node-name"
source_file {
# We must override the file extension to bypass the validation code
# in the Proxmox VE API.
file_name = "vmdk-file-name.img"
path = "path-to-vmdk-file"
}
}
resource "proxmox_virtual_environment_vm" "example" {
//...
disk {
datastore_id = "datastore-id"
# We must tell the provider that the file format is vmdk instead of qcow2.
file_format = "vmdk"
file_id = "${proxmox_virtual_environment_file.vmdk_disk_image.id}"
}
//...
}
Snippets Cannot Be Uploaded by Non-PAM Accounts
Due to limitations in the Proxmox VE API, certain files (snippets, backups) need to be uploaded using SFTP. This requires the use of a PAM account (standard Linux account).
Cluster Hardware Mappings Cannot Be Created by Non-PAM Accounts
Due to limitations in the Proxmox VE API, cluster hardware mappings must be created using the root
PAM account (standard Linux account) due to IOMMU interactions.
Hardware mappings allow the use of PCI "passthrough" and map physical USB ports.
Contributors
See CONTRIBUTORS.md for a list of contributors to this project.
Repository Metrics
Sponsorship
❤️ This project is sponsored by:
Thanks again for your continuous support, it is much appreciated! 🙏
Acknowledgements
This project has been developed with GoLand IDE under the JetBrains Open Source license, generously provided by JetBrains s.r.o.
